fix(quickfix list): avoid clobbering existing lists #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found a small issue with the quickfix list integration.
Setting the replace flag when sending grug-far results into the quickfix list truncates existing results. That's a problem because the quickfix list keeps a history of all the lists generated during the session, and you can navigate the history with
:cprev
and:cnext
. Which means that populating the list from grug overtakes whatever list is currently displaying.For example, imagine you have the lists in
:chistory
Then you navigate back to see the second list with
:cprev
.Then you use grug-far and send the results to the list:
Now I've lost
Some other plugin list
.Inserting a brand new entry seems like the desired behavior, not only prevents clobbering existing lists, but also helps you navigate previous grug-far results without opening the grug-far ui first.