feat: add previewLocation actions #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MagicDuck
requested changes
Sep 3, 2024
There was a problem hiding this comment.
@leisiji Thanks for your contribution! 😄 Looks good apart from some minor things. Also, please add a test for this action.
See: https://github.com/MagicDuck/grug-far.nvim/blob/main/CONTRIBUTING.md#testing
and example for goto action here:
grug-far.nvim/tests/base/test_goto.lua
Line 18 in fe915b2
edit: also please add a note about it to the README, maybe around here: https://github.com/MagicDuck/grug-far.nvim/blob/main/README.md#going-to--opening-result-location
leisiji
force-pushed
the
main
branch
2 times, most recently
from
238cabf to
d20e2a5
Compare
|
I have fixed the above and added a test for previewLocation action. |
MagicDuck
requested changes
Sep 5, 2024
|
All have been fixed. |
MagicDuck
approved these changes
Sep 5, 2024
|
perfect, thank you! Looks good! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new feature: previewing location in a floating window.
