improving perf of force redraw

MagicDuck · Aug 29, 2024 · e12bedb · e12bedb
1 parent 0d5ffde
commit e12bedb
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/lua/grug-far/actions/replace.lua b/lua/grug-far/actions/replace.lua
@@ -134,7 +134,7 @@ local function replace(params)
         state.actionMessage = update.message
       end
       renderResultsHeader(buf, context)
-      resultsList.throttledForceRedrawBuffer(buf)
+      resultsList.throttledForceRedrawBuffer(buf, context)
     end,
     on_finish = on_finish_all,
   })

diff --git a/lua/grug-far/actions/search.lua b/lua/grug-far/actions/search.lua
@@ -71,7 +71,7 @@ local function search(params)
       renderResultsHeader(buf, context)
 
       resultsList.appendResultsChunk(buf, context, data)
-      resultsList.throttledForceRedrawBuffer(buf)
+      resultsList.throttledForceRedrawBuffer(buf, context)
 
       if shouldAbortEarly then
         if state.abort.search then

diff --git a/lua/grug-far/actions/sync.lua b/lua/grug-far/actions/sync.lua
@@ -147,7 +147,7 @@ local function sync(params)
       end
       state.actionMessage = getActionMessage(nil, changesCount, changesTotal)
       renderResultsHeader(buf, context)
-      resultsList.throttledForceRedrawBuffer(buf)
+      resultsList.throttledForceRedrawBuffer(buf, context)
     end,
     on_finish = function(status, errorMessage, customActionMessage)
       if state.bufClosed then

diff --git a/lua/grug-far/render/resultsList.lua b/lua/grug-far/render/resultsList.lua
@@ -381,12 +381,16 @@ end
 
 --- force redraws buffer. This is order to apear more responsive to the user
 --- and quickly give user feedback as results come in / data is updated
+--- note that only the "top" range of lines is redrawn, including a bunch of lines
+--- after headerRow so that we immediately get error messages to show up
 ---@param buf integer
-function M.forceRedrawBuffer(buf)
+---@param context GrugFarContext
+function M.forceRedrawBuffer(buf, context)
   ---@diagnostic disable-next-line
   if vim.api.nvim__redraw then
     ---@diagnostic disable-next-line
-    vim.api.nvim__redraw({ buf = buf, flush = true })
+    vim.api.nvim__redraw({ buf = buf, flush = true, range = { 0, context.state.headerRow + 100 } })
+    -- vim.api.nvim__redraw({ buf = buf, flush = true })
   end
 end