Add problems chain and polygon
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frapac
requested changes
Feb 27, 2024
There was a problem hiding this comment.
Thank you for your contribution @tmigot !
I only have a few suggestions, summarizing to:
- passing explicitly the arguments to the functions
- using the newest NLP backend in JuMP (ie replacing
@NLobjectiveby@objectiveand equivalently for@NLconstraint). This is required to support ExaModels.
The docstrings look good to me. Maybe add a line to specify that these two models are taken from OptimizationProblems.jl?
|
@frapac I added the includes in the main file :). As mentioned in the report, polygon has several local minima so it is hard to test the objective value there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@frapac I kept the existing docstring, but we should probably unify with the other problems, what do you think?