Merge latest upstream changes #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try it for division via multiplication
thus mul from iterators too and improvemnts therein
remove colors from xml output (for the CI)
Revert "autoupdate"
Fixes failure to compile on GCC 13.
Add missing #include <cstdint> for (u)int64_t LGTM, thanks.
Add installation instructions for cloned repositories
Remove extra rules in README.md
testing div
There's one instance of VAR+=" value" in the configure script, but
that only works in bash. With dash, for example, it results in
checking whether gmp version is at least 40000... yes
./configure: 17953: REQUIRED_FLAGS+= : not found
We change it to a VAR="${VAR} value" instead.
Thanks ! configure.ac: fix a bashism
|
Don't merge the changes, just push the latest upstream commit. |
d-torrance
force-pushed
the
merge-upstream
branch
from
637b823
to
a18baf5
Compare
|
Sounds good -- I reset this branch to the one from my upstream PR. So it's just upstream's master branch Edit: I realized I didn't need that last commit since it's already been added with the last PR. So this branch is just exactly upstream's master, like Mahrud suggested. |
d-torrance
force-pushed
the
merge-upstream
branch
from
a18baf5
to
fc6cac7
Compare
|
This PR is no longer necessary as upstream has merged the fix for the GCC 15 bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should have paid more attention before opening #4, but we actually switched from using this fork for the M2 givaro submodule to the main upstream repository back in Macaulay2/M2#3324 because it includes some additional fixes for newer versions of GCC.
Until upstream merges my PR fixing the GCC 15 bug, I suppose we should go back to using this fork. So let's merge in all the latest upstream changes.