Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for Swift Package Manager #1

Closed
wants to merge 25 commits into from
Closed

Fix CI for Swift Package Manager #1

wants to merge 25 commits into from

Conversation

Patrick-Kladek
Copy link

Description

Fixes CI as discussed in maplibre#24

Tasks

  • add tests and make them pass
  • restructure project
  • add Testplan
  • ensure build & tests pass on GitHub

Infos for Reviewer

It seems that there were some tests that are not used by maplibre-navigation-ios like MapboxNavigationTests.testLanes() which uses iOSSnapshotTestCase. Therefore I've removed them.

StephanPartzsch and others added 6 commits March 16, 2024 09:30
* Adds configuration to speak or skip the first voice instruction at leg start.

* Fixes route voice controller when no route progress is given.
* Let speak instructions without route progress.

* Fixes typo and extends changelog.
Patrick-Kladek and others added 19 commits April 4, 2024 16:32
…n-ios into feature/spm-fix-ci

# Conflicts:
#	Examples/Swift/ViewController.swift
* SPM

* Remove carthage support

* Delete MapboxCoreNavigation.podspec

* Fix ExampleSwift

* Add to changelog

* Examples & tests in xcodeproj

* Clean up

* Append

* Update XcodeProj/MapboxNavigationTests/MapboxNavigationTests.swift

* Update XcodeProj/RouteTest/Fixture.swift

Co-authored-by: Giordano Menegazzi <[email protected]>

* Remove Carthage from workflow

* Fix merge

* Test plan

* Revert let voiceController change

* Revert CustomViewController changes

* Remove redundant import

* Restore iOS 12 support

* add tests and make them pass

* restructure project

* update gitignore

* Add TestPlan

* reduce swift-tools version as github images is not up to date

* install latest swift version for github actions run

* run via xcrun

* use xcodebuild with toolchain flag

* fix flag

* configure newest Xcode app

* investigate xcode-select

* xcode-select switch to correct path

* print all /Applications

* explicitly request macos-14

* try again

* pipe through xcbeautify

* enable github actions renderer in xcbeautify

* update name of workflow

* use spaces for indentation

* fix last missing indentation change

---------

Co-authored-by: Maarten Zonneveld <[email protected]>
Co-authored-by: Giordano Menegazzi <[email protected]>
@Patrick-Kladek Patrick-Kladek deleted the feature/spm-fix-ci branch May 12, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants