forked from maplibre/maplibre-navigation-ios
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI for Swift Package Manager #1
Closed
Patrick-Kladek
wants to merge
25
commits into
MaartenZonneveld:feature/swift-package-manager
from
Patrick-Kladek:feature/spm-fix-ci
Closed
Fix CI for Swift Package Manager #1
Patrick-Kladek
wants to merge
25
commits into
MaartenZonneveld:feature/swift-package-manager
from
Patrick-Kladek:feature/spm-fix-ci
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds configuration to speak or skip the first voice instruction at leg start. * Fixes route voice controller when no route progress is given.
* Let speak instructions without route progress. * Fixes typo and extends changelog.
…n-ios into feature/spm-fix-ci # Conflicts: # Examples/Swift/ViewController.swift
* SPM * Remove carthage support * Delete MapboxCoreNavigation.podspec * Fix ExampleSwift * Add to changelog * Examples & tests in xcodeproj * Clean up * Append * Update XcodeProj/MapboxNavigationTests/MapboxNavigationTests.swift * Update XcodeProj/RouteTest/Fixture.swift Co-authored-by: Giordano Menegazzi <[email protected]> * Remove Carthage from workflow * Fix merge * Test plan * Revert let voiceController change * Revert CustomViewController changes * Remove redundant import * Restore iOS 12 support * add tests and make them pass * restructure project * update gitignore * Add TestPlan * reduce swift-tools version as github images is not up to date * install latest swift version for github actions run * run via xcrun * use xcodebuild with toolchain flag * fix flag * configure newest Xcode app * investigate xcode-select * xcode-select switch to correct path * print all /Applications * explicitly request macos-14 * try again * pipe through xcbeautify * enable github actions renderer in xcbeautify * update name of workflow * use spaces for indentation * fix last missing indentation change --------- Co-authored-by: Maarten Zonneveld <[email protected]> Co-authored-by: Giordano Menegazzi <[email protected]>
…igation-ios into feature/spm-fix-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes CI as discussed in maplibre#24
Tasks
Infos for Reviewer
It seems that there were some tests that are not used by maplibre-navigation-ios like MapboxNavigationTests.testLanes() which uses iOSSnapshotTestCase. Therefore I've removed them.