Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design and navigation fix #87

Closed
wants to merge 6 commits into from

Conversation

nitzanto
Copy link

@nitzanto nitzanto commented Sep 5, 2023

Issue #84

  • Fixed the image responsive had to remove the xl:h-[90vh] and lg:mt-[1.2rem] classes since they were causing issues with responsiveness.

Fixed issue #78

  • Added Missing Navigation Links In The Footer
  • Fixed Navigation Links in the rest of the pages

@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maakaf-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 7:22pm

@nitzanto
Copy link
Author

nitzanto commented Sep 6, 2023

@RoyTennenbaum Waiting for your review, thanks ;)

Copy link
Member

@RoyTennenbaum RoyTennenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking your time to contribute :)

Please notice all links should be lowercase.

Additionally, the SVG did improve, but I am still not completely satisfied as the responsivity is a bit off. if you could find the cause it'll be a pleasure...
Attaching screenshots:
image it is not attached to top.

image It is weirdly affected by the viewport.

@nitzanto
Copy link
Author

nitzanto commented Sep 6, 2023

Thanks for taking your time to contribute :)

Please notice all links should be lowercase.

Additionally, the SVG did improve, but I am still not completely satisfied as the responsivity is a bit off. if you could find the cause it'll be a pleasure... Attaching screenshots: image it is not attached to top.

image It is weirdly affected by the viewport.

Hey Roy,

Regarding the links, all of the routes within the app folder start with a big letter therefore I had to change it because before it would navigate to a 404 page.

I think the solution to this could be done by changing the folder names to lowercase or creating a util function (component) which could take care of this issue, however I believe it would make stuff more complex.

About the design, I am a bit confused is the image supposed to be behind the text, next to the text? I am trying to understand what's the desired result, thank you :)

@RoyTennenbaum
Copy link
Member

@nitzanto not sure if you noticed, but folder names were changed, not sure if this pr is entirely relevant.
please make the changes accordingly and re-submit :)

@RoyTennenbaum
Copy link
Member

I am closing this pr as not relevant... no worries @nitzanto please try a different issue if you'd like there are several others as of today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants