Fix projects #292
Merged
Fix projects #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Tamir198
suggested changes
May 28, 2024
Closed
|
All requested changes have been completed. Please let me know if any further modifications are needed. |
Darkmift
reviewed
May 29, 2024
Darkmift
approved these changes
May 29, 2024
|
Good approach seems api response was flattened and simplified. |
|
i am a waiting for the approval |
Tamir198
approved these changes
May 30, 2024
|
Ok please let me know what this change is going to merge. I want to add in another branch the fix for images |
If I was not clear, I liked you changes - good job no need to change anything else |
Closed
Tamir198
reviewed
Jun 1, 2024
| if (!parsedProjects.success) { | ||
| throw new Error(`Failed to parse projects: ${parsedProjects.error}`); | ||
| } | ||
| console.log(parsedProjects.data[0]); | ||
|
|
There was a problem hiding this comment.
Hey, any reason to keep console log here?
| @@ -38,6 +38,8 @@ export default function ProjectCard({ | |||
|
|
|||
| const t = useTranslations('Projects'); | |||
|
|
|||
| console.log(owner, name) | |||
|
|
|||
|
Sorry I didn't noticed that this PR was already merged, if its got merged you can ignore my suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.