Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboard using fetch #277

Merged

Conversation

barel-mishal
Copy link
Contributor

No description provided.

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maakaf-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 8:56pm

@Darkmift
Copy link
Collaborator

Please resolve merge conflicts

Copy link
Contributor Author

@barel-mishal barel-mishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have saved it as a variable. Please note that this design is subject to change. This is why I did not prioritize making the code look better. While I believe it is very important to have clean code, due to the rapid pace of changes in the design and interface, I think it would be better to address this in a separate issue.

components/Leaderboard/Leaderboard.tsx Show resolved Hide resolved
@barel-mishal barel-mishal merged commit e89e036 into Maakaf:maakaf-leaderboard May 19, 2024
5 checks passed
@barel-mishal barel-mishal self-assigned this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants