Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding skeleton loading spinner in members page and Applying logic for member search in the input #250

Merged
merged 7 commits into from
May 10, 2024
Merged

Adding skeleton loading spinner in members page and Applying logic for member search in the input #250

merged 7 commits into from
May 10, 2024

Conversation

develad
Copy link
Contributor

@develad develad commented Apr 1, 2024 •
edited
Loading

Adding skeleton loading spinner in members page as described in Figma with improved design -> #246

localhost_3000_he_members (1)
localhost_3000_he_members
localhost_3000_he_members(iPhone 14 Pro Max)
localhost_3000_he_members (4)
localhost_3000_he_members (3)

@vercel Vercel
Copy link

vercel bot commented Apr 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maakaf-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 3:47pm

@develad develad mentioned this pull request Apr 1, 2024
Closed
Tamir198
Tamir198 suggested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@Tamir198 Tamir198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In English mode the memeber card looks like this :

image

It needs to have direction: rtl added, is this something you changed in this pr? If not we will open new issue for this

actions/fetchFilteredMemebers.ts Show resolved Hide resolved
components/Members/Skeleton/MdiAccountSearch.tsx Show resolved Hide resolved
components/Members/Skeleton/SkeletonCards.tsx Show resolved Hide resolved
components/ui/skeleton.tsx Show resolved Hide resolved
@develad
Copy link
Contributor Author

develad commented Apr 2, 2024 •
edited
Loading

In English mode the memeber card looks like this :

image

It needs to have direction: rtl added, is this something you changed in this pr? If not we will open new issue for this

I've build the skeletonCard component BASED OF the current memberCard component deployed design, I think the card was build before we had multi-language implanted in the website (didn't you built it?!) I think minor style fixes will do the trick like using the direction property as you've suggested with some additional styling

@Tamir198
Copy link
Contributor

Tamir198 commented Apr 3, 2024

@develad I will work on the wrong directions of the card in another pr,it's not something you broke with this pr.

@develad develad mentioned this pull request Apr 4, 2024
Closed
@develad develad changed the title Adding skeleton loading spinner in members page Adding skeleton loading spinner in members page and Applying logic for member search in the input Apr 16, 2024
@Darkmift
Copy link
Collaborator

Apologies for the delayed response.
Please resolve and I will review the PR for merge @develad

@Darkmift Darkmift merged commit d176f7a into Maakaf:main May 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tamir198 Tamir198 Tamir198 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@develad @Tamir198 @Darkmift