Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

214 change add project form state managmant #221

Merged
merged 19 commits into from
Mar 28, 2024

Conversation

Tamir198
Copy link
Contributor

I added new state management to useForm and Zod validations.

Added translations for the modal as well.

The form is not 100% done but this pr is focused on changing the state of the form.

image

@Tamir198 Tamir198 linked an issue Mar 26, 2024 that may be closed by this pull request
Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maakaf-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 9:25am

Copy link
Collaborator

@Darkmift Darkmift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add RTL support based on locale
  • Form errors work pretty good but there's room for improvement.
  • At present can the form be submitted?

@Tamir198
Copy link
Contributor Author

The form can be submitted (your ide console should print the data after the form is submitted) but right now there is no UI feedback to the user.

Also fixed the direction of the form according to the language

@Darkmift Darkmift merged commit e2a5272 into main Mar 28, 2024
5 checks passed
@Darkmift Darkmift deleted the 214-change-add-project-form-state-managmant branch March 28, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change add project form state managmant
2 participants