Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Project href,Added LINKS const #144

Merged
merged 6 commits into from
Mar 10, 2024
Merged

Conversation

Darkmift
Copy link
Collaborator

@Darkmift Darkmift commented Mar 6, 2024

  • Due to the repeating nature of links across the project I introduced a const LINKS and refactored all href I could track down touse it as a links SSOT

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maakaf-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2024 0:00am

Copy link
Contributor

@Tamir198 Tamir198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are looking good generally.

One thing that I would do is extract duplicated UI into a separate reusable component.
After the changes there are places in the code where I think we could extract duplications, for example:

      <p>
        ממש אצלנו בקהילה!{' '}
        <span className="underline  text-purple-500">
          <a href={LINKS.PROJECTS} target="_blank">
            בעמוד הפרויקטים
          </a>
        </span>{' '}
        תוכלו למצוא מידע על פרויקטים בקוד פתוח במגוון שפות ותחומים. <br />
        <span className="underline  text-purple-500">
          <a href={LINKS.DISCORD}target="_blank">
            בדיסקורד שלנו
          </a>
        </span>{' '}

components/MembersPics/MembersPics.tsx Show resolved Hide resolved
config/consts.ts Show resolved Hide resolved
@Darkmift Darkmift merged commit 2b69d74 into main Mar 10, 2024
5 checks passed
@Darkmift Darkmift deleted the issue-134-links-fixes branch March 10, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants