-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Project href,Added LINKS const #144
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are looking good generally.
One thing that I would do is extract duplicated UI into a separate reusable component.
After the changes there are places in the code where I think we could extract duplications, for example:
<p>
ממש אצלנו בקהילה!{' '}
<span className="underline text-purple-500">
<a href={LINKS.PROJECTS} target="_blank">
בעמוד הפרויקטים
</a>
</span>{' '}
תוכלו למצוא מידע על פרויקטים בקוד פתוח במגוון שפות ותחומים. <br />
<span className="underline text-purple-500">
<a href={LINKS.DISCORD}target="_blank">
בדיסקורד שלנו
</a>
</span>{' '}
LINKS
and refactored all href I could track down touse it as a links SSOT