Skip to content

Commit

Permalink
Revert back to property comparison of qicon name() instead of cacheKey()
Browse files Browse the repository at this point in the history
  • Loading branch information
fehlix committed Jun 21, 2024
1 parent 2b298d9 commit ff2b265
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions debian/changelog
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
mx-packageinstaller (24.6.06) mx; urgency=medium

* Fix: revert back to property comparison of qicon name() instead of cacheKey()

-- fehlix <[email protected]> Fri, 21 Jun 2024 05:27:32 -0400

mx-packageinstaller (24.6.05) mx; urgency=medium

* Fix: fallback for identical theme icons for installed and upgradable packages
Expand Down
2 changes: 1 addition & 1 deletion mainwindow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1940,7 +1940,7 @@ void MainWindow::setIcons()
const QIcon theme_icon_upgradable = QIcon::fromTheme(icon_upgradable, backup_icon_upgradable);
const QIcon theme_icon_installed = QIcon::fromTheme(icon_installed, backup_icon_installed);

const bool force_backup_icon = (theme_icon_upgradable.cacheKey() == theme_icon_installed.cacheKey());
const bool force_backup_icon = (theme_icon_upgradable.name() == theme_icon_installed.name());

qicon_installed = force_backup_icon ? backup_icon_installed : theme_icon_installed;
qicon_upgradable = force_backup_icon ? backup_icon_upgradable : theme_icon_upgradable;
Expand Down

0 comments on commit ff2b265

Please sign in to comment.