Manage not found cellar object for logo/signature and generate PDF without logo/signature in case of missing image position #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicguillois
changed the title
…DF without logo/signature in case of missing image position
loicguillois
force-pushed
the
fix-campaign-pdf
branch
from
dfe97fd to
847c9d9
Compare
loicguillois
commented
Dec 19, 2024
packages/draft/src/pdf.ts
Outdated
| height: toPoints(imageHeight) | ||
| }); | ||
| if (position) { | ||
| logger.error(`Image position not found for page ${i}`) |
There was a problem hiding this comment.
l'idée est d'éviter qu'une erreur sur un seul logement empêche de générer le PDF pour tout les autres. le parti pris est de générer la page incriminée sans logo/signature
Falinor
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.