Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test only changed projects #1002

Merged
merged 8 commits into from
Nov 13, 2024
Merged

Test only changed projects #1002

merged 8 commits into from
Nov 13, 2024

Conversation

Falinor
Copy link
Collaborator

@Falinor Falinor commented Nov 13, 2024

No description provided.

@Falinor Falinor requested a review from loicguillois November 13, 2024 11:41
@Falinor Falinor self-assigned this Nov 13, 2024
@Falinor Falinor force-pushed the build-only-changed-projects branch from e8fdd01 to 6dadc38 Compare November 13, 2024 11:49
@@ -67,7 +67,7 @@ jobs:
run: yarn lint

- name: Test
run: yarn test
run: yarn test --since --parallel --include-dependents
Copy link
Collaborator Author

@Falinor Falinor Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

À chaque push, lerna exécute en parallèle les tests des packages qui ont changé + les packages qui dépendent d’eux. Le changement est évalué par rapport au dernier tag connu c’est-à-dire par rapport à la branche de destination si on est sur une PR.

À voir sur main comment ça se comporte

@@ -1,5 +1,6 @@
{
"name": "@zerologementvacant/e2e",
"version": "0.0.1",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Les packages doivent tous avoir une version définie pour être détectés. Idéalement, la même version.

@@ -1,4 +1,5 @@
{
"extends": "./tsconfig.json",
"references": [{ "path": "../utils/tsconfig.build.json" }],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C’était manquant et ça causait une erreur de build car la dépendance n’était pas définie

@Falinor Falinor force-pushed the build-only-changed-projects branch from 63b6013 to df059a9 Compare November 13, 2024 13:49
@Falinor Falinor merged commit 0f09aff into main Nov 13, 2024
6 checks passed
@Falinor Falinor deleted the build-only-changed-projects branch November 13, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants