Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Symfony 7.2 #1091

Merged
merged 1 commit into from
Dec 16, 2024
Merged

🚀 Symfony 7.2 #1091

merged 1 commit into from
Dec 16, 2024

Conversation

mmarchois
Copy link
Collaborator

No description provided.

@mmarchois
Copy link
Collaborator Author

Easy admin est cassé, j'ai créé une issue sur le repo EasyCorp/EasyAdminBundle#6605

@mmarchois
Copy link
Collaborator Author

A constater également qu'il n'y a plus de debug toolbar

@florimondmanca
Copy link
Collaborator

Je confirme

Mais ça vient d'un fichier php dans le cache twig?

in var/cache/dev/twig/07/072aecd2ae7e72fcaf4bf059dcfdeb50.php (line 958)

                        if ( !Twig\Extension\CoreExtension::testEmpty(CoreExtension::getAttribute($this->env, $this->source, $context["item"], "icon", [], "any", false, false, false, 107))) {
                            yield $this->env->getRuntime('Symfony\UX\TwigComponent\Twig\ComponentRuntime')->render("ea:Icon", ["name" => CoreExtension::getAttribute($this->env, $this->source, $context["item"], "icon", [], "any", false, false, false, 107)]);
                        }
                        // line 108
                        yield "                                        ";
                        yield $this->env->getRuntime('Twig\Runtime\EscaperRuntime')->escape($this->extensions['Symfony\Bridge\Twig\Extension\TranslationExtension']->trans(CoreExtension::getAttribute($this->env, $this->source, $context["item"], "label", [], "any", false, false, false, 108), [], $_v0), "html", null, true);
                        yield "
                                        </a>
                                    ";
                    }
                    // line 111


Aussi est-ce que chez toi la toolbar Symfony ne s'affiche plus non plus ?

Elle s'affiche en HTML brut en bas de la page

J'ai pourtant fait make assets

Screenshot 2024-11-29 at 10-52-07 Mon espace - DiaLog

@florimondmanca
Copy link
Collaborator

Il y aura sûrement une 7.2.1

@mmarchois
Copy link
Collaborator Author

Intéressant EasyCorp/EasyAdminBundle#6605 (comment)

@mmarchois mmarchois force-pushed the update_deps branch 2 times, most recently from 6775bfb to 6fdae70 Compare December 11, 2024 16:27
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.88%. Comparing base (1a9ffac) to head (8fd7ab3).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1091   +/-   ##
=========================================
  Coverage     98.88%   98.88%           
  Complexity     1822     1822           
=========================================
  Files           364      364           
  Lines          7873     7873           
=========================================
  Hits           7785     7785           
  Misses           88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmarchois
Copy link
Collaborator Author

@florimondmanca il ne reste plus que la debug toolbar à fix

@mmarchois mmarchois force-pushed the update_deps branch 2 times, most recently from 74f0df8 to f6a2b2c Compare December 12, 2024 09:20
@mmarchois
Copy link
Collaborator Author

symfony/symfony#59045

@mmarchois
Copy link
Collaborator Author

Prêt à la review @florimondmanca

@mmarchois mmarchois self-assigned this Dec 12, 2024
@mmarchois
Copy link
Collaborator Author

@florimondmanca on peut merge je pense

Copy link
Collaborator

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mmarchois mmarchois merged commit 401f562 into main Dec 16, 2024
5 checks passed
@mmarchois mmarchois deleted the update_deps branch December 16, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants