Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

27 fixed link to book #28

Merged
merged 17 commits into from
Dec 1, 2023
Merged

27 fixed link to book #28

merged 17 commits into from
Dec 1, 2023

Conversation

emtelgen
Copy link
Collaborator

removed library link
added information to direct users to specific links

@emtelgen
Copy link
Collaborator Author

  • failed due to mkdocs deploy, not sure why
  • i put 27 in the title because it goes with issue 27 but it didn't add it to the issue information not sure why that did not happen

@billspat
Copy link
Collaborator

related to your comment: "i put 27 in the title because it goes with issue 27" I think in PRs and in Commit messages you have to prepend the issue number with number sign: " #27 " to get them to link. You could edit the title of this PR to "#27 fixed link to book" and that should work.

@billspat billspat changed the base branch from main to test_merge_pr28 December 1, 2023 16:21
@billspat
Copy link
Collaborator

billspat commented Dec 1, 2023

test run on this old pull request into a test branch. Don't have a great way to test other than pulling the branch onto a computer and building with mkdocs.

@billspat billspat merged commit ea01a9a into MSU-ICER:test_merge_pr28 Dec 1, 2023
1 check failed
billspat added a commit that referenced this pull request Dec 1, 2023
several fixes to session 5, issue #31 
*authored-by: emtelgen <[email protected]>

Co-authored-by: emtelgen <[email protected]>
@billspat billspat mentioned this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants