Added support for PackageVersion to resolve ACP Bug as well as VMware Driver Package Support #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for 1E Alternate Content Provider
Added support for PackageVersion for ACP bug as well as VMware Driver Package support.
Lintnotes
changed the title
|
While I understand this is an old PR at this point, it's hard to see what code was actually changed. Would you please create a new one where not 3K+ lines are changed due to indentation? |
|
Hi Nickolaj.
Ill wait and re-evaluate your latest code when its ready with my customer and see if there is still a need for the ACP additions. While I know this code is predominantly used for Windows Client deployments my customer leverages this for Server OS Deployments as well. Do you have any interest in extending this to support VMware Drivers, and Server Operating Systems? The required code changes are pretty low but if not ill just keep extending this for my customer.
Thanks,
Brandon A. Linton | ***@***.******@***.***> | Mobile 610.883.2453
From: Nickolaj Andersen ***@***.***>
Sent: Sunday, March 6, 2022 3:03 PM
To: MSEndpointMgr/ModernDriverManagement ***@***.***>
Cc: Brandon Linton ***@***.***>; Author ***@***.***>
Subject: Re: [MSEndpointMgr/ModernDriverManagement] Added support for PackageVersion to resolve ACP Bug as well as VMware Driver Package Support (#94)
While I understand this is an old PR at this point, it's hard to see what code was actually changed. Would you please create a new one where not 3K+ lines are changed due to indentation?
-
Reply to this email directly, view it on GitHub<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMSEndpointMgr%2FModernDriverManagement%2Fpull%2F94%23issuecomment-1060029775&data=04%7C01%7C%7C054893a0e8bf4866fd6708d9ffac4f2e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637821937792742101%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=4XoeYmGMi38Gz7v1OwPaWNkTW2LCZn3Y%2BW0OIx62qPo%3D&reserved=0>, or unsubscribe<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGG22ZK3X25M5FNXKVNYWCLU6UFPDANCNFSM42EKOYPA&data=04%7C01%7C%7C054893a0e8bf4866fd6708d9ffac4f2e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637821937792742101%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=v1mdZwhdMAh%2FRN5NqG1kpwIkvfUeMQmHbeXIV%2Ff1PsA%3D&reserved=0>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for 1E Alternate Content Provider to resolve issue where OSDDownloadContent.exe always pulls version1 of a package when called externally.