Fix test_features_and_tags #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to find `geometric_features/features_and_tags.json` using `importlib.resources` and we want to store the comparison file in the temporary directory generated for the test, not the current directory.
xylar
force-pushed
the
fix-test-features-and-tags
branch
from
eb4b195 to
b507df5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to find
geometric_features/features_and_tags.jsonusingimportlib.resourcesand we want to store the comparison filein the temporary directory generated for the test, not the current
directory.
This merge also removes
imortlib_requests, which is included in all supported versions of python.