Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sea-ice historical median features #218

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Dec 20, 2024

The name of the feature needs to be exactly the same as the folder it's in (except ' ' --> '_') and the name of the component needs to be seaice instead of sea ice.

@xylar xylar added the bug label Dec 20, 2024
@xylar xylar requested a review from alexolinhager December 20, 2024 10:18
@xylar xylar self-assigned this Dec 20, 2024
@xylar
Copy link
Collaborator Author

xylar commented Dec 20, 2024

@alexolinhager, for future development, you may save debugging time by following these instructions:
https://mpas-dev.github.io/geometric_features/main/adding_features.html

They involve creating features and then splitting them out with gf.split(fc), which will automatically name the folders based on the feature names, components, etc. (and will catch some incorrect properties along the way).

Likewise, they use write_feature_names_and_tags(gf.cacheLocation) rather than manually editing geometric_features/features_and_tags.json to ensure that the contents of the latter file are consistent with the contents of the geometric_data files.

@xylar
Copy link
Collaborator Author

xylar commented Dec 21, 2024

Approved by @alexolinhager in #220

@xylar xylar merged commit da0691f into MPAS-Dev:main Dec 21, 2024
5 checks passed
@xylar xylar deleted the fix-seaice-historical-median-features branch December 21, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant