Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISMIP6 Greenland region masks that extend beyond ice edge #824

Merged
merged 3 commits into from
May 23, 2024

Conversation

trhille
Copy link
Collaborator

@trhille trhille commented May 23, 2024

This merge adds ISMIP6 region masks to the Greenland mesh, which extend beyond ice edge and will be useful for regional stats. It also makes use of the allTags argument when calling GeometricFeatures.read() instead of looping over tags for greater flexibility.

Note: This requires geometric_features version 1.4.0, which is not yet in the latest version of compass.

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

Add ISMIP6 Greenland regions that extend beyond ice edge.
Use allTags argument instead of looping over tags to facilitate
more flexible use of tags.
@trhille trhille requested review from xylar and andrewdnolan May 23, 2024 02:05
@trhille
Copy link
Collaborator Author

trhille commented May 23, 2024

Testing

Here are the ISMIP6 basins on a 30–100 km GIS mesh:
image
image
image
image
image
image
image

The Zwally basins remain unchanged (I won't bother adding screenshots here).

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@trhille
Copy link
Collaborator Author

trhille commented May 23, 2024

Thanks, @xylar. What's the protocol for a PR like this that requires updates to the compass environment (geometric_features=1.4.0)?

@xylar
Copy link
Collaborator

xylar commented May 23, 2024

Ah, missed that. You also need to bump to alpha.2 (maybe in a couple of places).

@xylar
Copy link
Collaborator

xylar commented May 23, 2024

I'll push a commit to update geometric_features and compass itself. I'd also like to add a commit to make the ocean masks for these regions in files_for_e3sm if that's okay with you.

xylar added 2 commits May 23, 2024 08:44
These are generated in the `files_for_e3sm` tests case that is
part of generating new ocean and sea-ice meshes for E3SM.
Comment on lines -85 to +86
'Arctic Sea Ice Regions', 'Ocean Basins',
'Ocean Subbasins', 'ISMIP6 Regions']
'Arctic Sea Ice Regions', 'Greenland Regions',
'Ocean Basins', 'Ocean Subbasins', 'ISMIP6 Regions']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trhille, let me know if you're okay with including this. I'll run a quick test.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with the qu240_for_e3sm and it produced the Greenland region masks as expected.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's fine with me.

@andrewdnolan
Copy link
Contributor

Tested on perlmutter with the default parameters and everything worked fine for me!

landice/greenland/mesh_gen
  * step: mesh
  test execution:      SUCCESS
  test runtime:        17:13
Test Runtimes:
17:13 PASS landice_greenland_mesh_gen
Total runtime 18:37
PASS: All passed successfully!

Also took a look over the code and everything looks good to me!

@trhille trhille merged commit 675d4b0 into MPAS-Dev:main May 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants