-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ISMIP6 Greenland region masks that extend beyond ice edge #824
Add ISMIP6 Greenland region masks that extend beyond ice edge #824
Conversation
Add ISMIP6 Greenland regions that extend beyond ice edge. Use allTags argument instead of looping over tags to facilitate more flexible use of tags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks, @xylar. What's the protocol for a PR like this that requires updates to the compass environment (geometric_features=1.4.0)? |
Ah, missed that. You also need to bump to alpha.2 (maybe in a couple of places). |
I'll push a commit to update geometric_features and compass itself. I'd also like to add a commit to make the ocean masks for these regions in |
These are generated in the `files_for_e3sm` tests case that is part of generating new ocean and sea-ice meshes for E3SM.
'Arctic Sea Ice Regions', 'Ocean Basins', | ||
'Ocean Subbasins', 'ISMIP6 Regions'] | ||
'Arctic Sea Ice Regions', 'Greenland Regions', | ||
'Ocean Basins', 'Ocean Subbasins', 'ISMIP6 Regions'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trhille, let me know if you're okay with including this. I'll run a quick test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this with the qu240_for_e3sm
and it produced the Greenland region masks as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's fine with me.
Tested on
Also took a look over the code and everything looks good to me! |
This merge adds ISMIP6 region masks to the Greenland mesh, which extend beyond ice edge and will be useful for regional stats. It also makes use of the
allTags
argument when callingGeometricFeatures.read()
instead of looping over tags for greater flexibility.Note: This requires geometric_features version 1.4.0, which is not yet in the latest version of compass.
Checklist
Testing
in this PR) any testing that was used to verify the changes