Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up parabolic bowl convergence plot #823

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Clean-up parabolic bowl convergence plot #823

merged 1 commit into from
Jun 6, 2024

Conversation

cbegeman
Copy link
Collaborator

@cbegeman cbegeman commented May 17, 2024 •
edited
Loading

Invert the x-axis for the parabolic bowl convergence plot

@cbegeman
Copy link
Collaborator Author

Testing

The standard, ramp parabolic bowl test case has been run on chrys with intel, impi compiler.

image

@cbegeman cbegeman requested a review from sbrus89 May 17, 2024 17:24
@cbegeman cbegeman added the bug Something isn't working label May 17, 2024
@cbegeman cbegeman self-assigned this May 17, 2024
@sbrus89
Copy link
Collaborator

sbrus89 commented May 17, 2024

I realized I had made a change in #785 to fix the difference in the slopes between the actual and ideal convergence curves (see latest comment on #785). However, this PR makes the x axis consistent with other convergence plots in compass/polaris.

sbrus89
sbrus89 approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@sbrus89 sbrus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by inspection. Thanks for fixing this @cbegeman.

@cbegeman cbegeman changed the title Fix parabolic bowl convergence plot Clean-up parabolic bowl convergence plot May 17, 2024
@cbegeman cbegeman added clean-up and removed bug Something isn't working labels May 17, 2024
@cbegeman cbegeman merged commit 1588d78 into MPAS-Dev:main Jun 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrus89 sbrus89 sbrus89 approved these changes

Assignees

@cbegeman cbegeman

Labels
clean-up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbegeman @sbrus89