Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add histograms of areaCell and dcEdge to init plots #822

Merged
merged 1 commit into from
May 13, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented May 9, 2024

Last 2 plots in:
initial_state

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar
Copy link
Collaborator Author

xylar commented May 9, 2024

Testing

I ran the IcoswISC30 mesh and init tests on Chrysalis to produce the image above.

@xylar xylar added enhancement New feature or request ocean labels May 9, 2024
@xylar xylar self-assigned this May 9, 2024
@xylar xylar requested review from golaz and proteanplanet May 9, 2024 22:56
@xylar
Copy link
Collaborator Author

xylar commented May 9, 2024

@golaz and @proteanplanet, are you okay with these or are there more tweaks you'd like to see?

@xylar
Copy link
Collaborator Author

xylar commented May 9, 2024

The frequency is on a log scale for other plots, Perhaps that would make sense here, too. I'll try that.

@xylar
Copy link
Collaborator Author

xylar commented May 9, 2024

initial_state

Yeah, probably the version on a log scale makes a bit more sense for consistency and because there's a bit more info there.

@xylar xylar force-pushed the add-mesh-histograms branch from f9ebc4b to 587fb78 Compare May 9, 2024 23:13
@xylar
Copy link
Collaborator Author

xylar commented May 9, 2024

I fixed the min/max values to be the original ones (m^2 and m, rather than km^2 and km) to hopefully avoid potential confusion.

Copy link

@proteanplanet proteanplanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by visual inspection. Thanks for adding this as a QC metric.

@xylar
Copy link
Collaborator Author

xylar commented May 13, 2024

Thanks @proteanplanet!

@xylar xylar merged commit e2810ea into MPAS-Dev:main May 13, 2024
4 checks passed
@xylar xylar deleted the add-mesh-histograms branch May 13, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants