Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MALI-Dev submodule to latest develop #796

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Mar 17, 2024

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar requested review from matthewhoffman and trhille March 17, 2024 09:27
@xylar xylar self-assigned this Mar 17, 2024
@xylar
Copy link
Collaborator Author

xylar commented Mar 17, 2024

Testing

I was able to run the full_integration suite on Perlmutter with Gnu using this updated submodule as well as #793

@xylar
Copy link
Collaborator Author

xylar commented Mar 17, 2024

@matthewhoffman and @trhille, this seems like a good time to update the MALI-Dev submodule. What do you think?

@xylar
Copy link
Collaborator Author

xylar commented Mar 17, 2024

Assuming we want to test #793 on the latest MALI-Dev, this update will help me (and @andrewdnolan) do that.

Copy link
Member

@matthewhoffman matthewhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is overdue. Thanks, for setting it up and testing it, @xylar .

Trevor is on vacation this week, so I'll remove the review from him.

@matthewhoffman matthewhoffman removed the request for review from trhille March 18, 2024 16:41
@matthewhoffman
Copy link
Member

I updated the submodule to develop as of today (86f24750e4) to get 2 new merges this week. I tested full_integration on Chicoma and all tests pass. @xylar , feel free to merge at will once the checks complete.

@xylar xylar merged commit 2bd02b7 into MPAS-Dev:main Mar 20, 2024
4 checks passed
@xylar xylar deleted the update-mali-dev branch March 20, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants