-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mpas_tools to 0.31.0 and compass to 1.2.0-alpha.10 #792
Conversation
I will rebase and test the PR suite once #791 goes in. |
@trhille and @matthewhoffman, sorry this took awhile. This is a PR to bring in the newest MPAS-Tools release which I think has all the features you need. I'll test on the ocean side to make sure things are either BFB or we understand why things changed. Please make sure to set up a new conda environment (or recreate your existing one) and let me know if you're seeing the features you're hoping to make use of from |
Even though it's not really used...
35b46a2
to
0f25f31
Compare
TestingI ran the There appear to be small differences in the coastline in Icos240 mesh that are likely at the level of roundoff. While I haven't been able to point to a specific cause, I don't see any cause for concern. As a result of having a different number of cells, all the Icos240 tests fail the baseline check. All other tests pass.
|
@matthewhoffman and @trhille, it might be best to fold this into an update to v1.3.0-alpha.1 that also includes #788. I may also want to do a new release of MPAS-Tools so MPAS-Dev/MPAS-Tools#557 is available. |
@xylar , combining those updates makes sense to me. |
Closing this in favor of #793 |
The update MPAS-Tools package brings in some features needed for land-ice test cases as well as several bug fixes. See https://github.com/MPAS-Dev/MPAS-Tools/releases.
Checklist
Testing
in this PR) any testing that was used to verify the changes