Fix bug in limiting cull distance #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assertion and the error message did not agree. We want to make the assertion match the error message, limiting cull_distance to be less than 3.0 * max(high_dist, high_dist_bed).
|
@trhille , looking at this again, I think the proper thing to do is delete the assertion and its message. What this bit of code was meant to do was stick coarse resolution out past the boundary of the culled mesh so that jigsaw runs faster by not having the highest resolution over a huge area that later gets thrown away. This bit of code does that automatically by setting the coarsest resolution at a (hopefully) safe distance beyond the specified cull_distance. That logic has nothing to do with the relation between cull_distance and the high_dist, so no check actually needs to happen related to that. I'm not sure what I was thinking when I wrote the assertion, but I don't think it makes sense, and we should just remove it. |
Remove unnecessary assertion about cull_distance, as this is handled by the logic that follows.
matthewhoffman
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge removes an unnecessary assertion about the value of
cull_distance, since it is handled by other logic.