Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to pyremap 1.1.0 #698

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Update to pyremap 1.1.0 #698

merged 2 commits into from
Sep 20, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Sep 18, 2023 •
edited
Loading

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar
Update to pyremap >=1.1.0
c558f37
@xylar
Update compass tests for pyremap >=1.1.0
28855aa 
This means moving from `MpasMeshDescriptor` to `MpasCellMeshDescriptor`
and `MpasVertexMeshDescriptor`.
@xylar xylar added in progress This PR is not ready for review or merging dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script framework labels Sep 18, 2023
@xylar xylar self-assigned this Sep 18, 2023
@xylar
Copy link
Collaborator Author

xylar commented Sep 18, 2023

Testing

This is non-bit-for-bit for the pr suite, specifically for the QU240 init test, but the changes are small -- ~1e-9. This is likely due to changing to SCRIP files from ESMF grid files when remapping topography.

I also tested that files_for_e3sm runs for the QU240 mesh with these changes.

@xylar xylar marked this pull request as draft September 18, 2023 10:29
@xylar
Copy link
Collaborator Author

xylar commented Sep 18, 2023

Because of the non-bit-for-bit changes, this shouldn't be merged until after #691, #668 and #669.

@xylar xylar removed the in progress This PR is not ready for review or merging label Sep 20, 2023
@xylar xylar marked this pull request as ready for review September 20, 2023 11:22
@xylar
Copy link
Collaborator Author

xylar commented Sep 20, 2023

I will tag #668 before the merge commit (i.e. excluding this merge) so we can get this in. The new meshe in #699, #700 and #701 should use this new version of pyremap.

@xylar xylar merged commit 6fd54f3 into MPAS-Dev:main Sep 20, 2023
4 checks passed
@xylar xylar deleted the update-to-pyremap-1.1.0 branch September 20, 2023 11:24
@xylar xylar mentioned this pull request Sep 20, 2023
Merged
@xylar xylar mentioned this pull request Oct 4, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xylar