Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort mesh indices before saving culled global ocean meshes #657

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jul 26, 2023

We need to create the graph file only after sorting has happened.

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added enhancement New feature or request ocean in progress This PR is not ready for review or merging labels Jul 26, 2023
@xylar xylar self-assigned this Jul 26, 2023
@xylar
Copy link
Collaborator Author

xylar commented Jul 26, 2023

Tesitng

So far, the ecwisc30to60 test suite has run successfully (except for the failing validation in #331) through the dynamic_adjustment phase using this branch!

I'm still running files_for_e3sm but don't expect any surprises there.

We need to create the graph file only after sorting has happened.
@xylar xylar force-pushed the sort-mesh-indices branch from 4baabc2 to a3ba192 Compare August 8, 2023 12:06
@xylar xylar marked this pull request as ready for review August 8, 2023 12:06
@xylar
Copy link
Collaborator Author

xylar commented Aug 8, 2023

Further testing

After updating to the released MPAS-Tools package in #662, I'm retesting through files_for_e3sm with the following meshes:

@xylar xylar merged commit 1b820d3 into MPAS-Dev:main Aug 9, 2023
@xylar xylar deleted the sort-mesh-indices branch August 9, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in progress This PR is not ready for review or merging ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant