LandIce: Added tests using the FO depth integrated model #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestingI ran the full_integration suite with this branch merged into #641 (required to get the version of Albany that includes MOLHO). I compared the diagnostic velocity solution for the Thwaites decomp test between FO and MOLHO: 
|
matthewhoffman
force-pushed
the
depth_integrated_model
branch
5 times, most recently
from
4d29c18 to
fa5186e
Compare
Options for Cubature Rules changed in Albany, consequently we are updating the tests input files. Also removed the unused outdated input file albany_schoof_input.yaml
|
#641 is merged. |
Added the following tests using the FO depth integrated model introduced in Albany PR sandialabs/Albany#956: landice/thwaites/fo-depthInt_decomposition_test landice/thwaites/fo-depthInt_restart_test landice/humboldt/mesh-3km_restart_test/velo-fo-depthInt_calving-von_mises_stress_damage-threshold_faceMelting
matthewhoffman
force-pushed
the
depth_integrated_model
branch
from
fa5186e to
0f6f234
Compare
matthewhoffman
approved these changes
Aug 4, 2023
|
(forgot to actually merge this after checks completed after rebase two weeks ago...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add tests using the FO depth integrated model introduced in Albany PR sandialabs/Albany#956.
In particular we added decomposition and restart tests for Thwaites and Humboldt glaciers.
We also updated tests' input files to comply with Albany PR sandialabs/Albany#953, where options for integration rules changed.
Removed the unused and outdated input file
albany_schoof_input.yamlTesting
Checklist
Testingin this PR) any testing that was used to verify the changes