-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove xtime variable from ocean climatology #486
Remove xtime variable from ocean climatology #486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hollyhan. Have you tested this? I'm approving by inspection, but am also happy to test this tomorrow when Cori is back up.
@trhille - I haven't tested it, thanks to Cori being down. It was an easy/straightforward fix to make, but it would be great to test it if it's not too much for you. Thanks so much, trevor! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right to me, too. But I would prefer not to merge until someone has done some testing.
I tested this on Cori and it worked as expected. Thanks for taking care of this @hollyhan! |
|
This PR address the issue created by @trhille (#463) on having the
xtime
variable in the processed ocean climatology thermal forcing file in theismip6_forcing
landice test group.closes #463