This repository has been archived by the owner on Oct 23, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Moab instance for mpas_ocean #1456
Open
iulian787
wants to merge
17
commits into
MPAS-Dev:ocean/develop
Choose a base branch
from
iulian787:moab_links
base: ocean/develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
similar to PNETCDF; it needs to have MOAB environment defined to the installation point (such as $(MOAB)/lib/moab.make exists, includes are at $(MOAB)/include) MOAB should be build with at least hdf5, parallel because it is c++, we also add -lstdc++ to the link line Maybe there is a better way
only if MOAB env var is defined TODO: when can we read vertex coordinates more efficiently? also, need to release memory allocated for reading the vertices
use "HAVE_MOAB" and "MOAB_PATH", instead of USE_MOAB and MOAB PIO , NETCDF are still showing the path
before bootstrapping
also, clear memory for vertex fields that were created for MOAB
also, use mesh pool
bootstrap is not changed anymore
will make sure MOAB paths are defined correctly
iulian787
force-pushed
the
moab_links
branch
from
November 30, 2017 23:44
e100606
to
7b6bab8
Compare
some ghost vertices are duplicated and not resolved, as resolving nvolves only boundary vertices
before, halo vertices were created, and they were not necessary also, the correct number of vertices are recovered
for atmosphere mesh, this was implicit because I called ghosting; ghosting was not necessary, but update mesh info is
mpas ocean will use MOAB_MPAS_INSIDE_E3SM if inside E3SM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of coupler modernization, (CMDV project), mpas mesh will be instanced using MOAB data structures, which will later help with tempestremap and online coupling
it is using data retrieved from blocks, with mpas_pool routines; currently it is tested for the case when there is one block per task (mesh partitioned in advance using gpmetis)
MOAB mesh is instanced when core_init is finished
There are HAVE_MOAB guards for relevant code; MOAB needs to be built in advance, and MOAB_PATH needs to be defined as an environment variable for standalone build/run (same way PIO and PNETCDF, NETCDF env vars are defined)
tested on gfortran compiler