cub::DeviceRadixSor works with a hack:
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbird
reviewed
Oct 24, 2024
| return child; | ||
| } | ||
|
|
||
| /* Remove garbage particles, holes in sph chunk, and holes in bh buffer. |
There was a problem hiding this comment.
You can remove this function and the functions it calls from this file: no need to port it to gpu.
sbird
reviewed
Oct 24, 2024
| if (!SLOTS_ENABLED(ptype, sman)) | ||
| continue; | ||
| // Sort the used ones by their location in the P array | ||
| qsort_openmp(sman->info[ptype].ptr, |
There was a problem hiding this comment.
Can we port this to cub::DeviceRadixSort as well?
- Code compiles and a test in tests/cuv_sort.cu outputs a correct answer HACK: combined Topkey, key into a single unit64_t. - This is to avoid using a struct with two uint32_t members. Which is not supported by cub::DeviceRadixSort::SortPairs. - TODO: use `thrust::sort_by_key` instead of `cub::DeviceRadixSort::SortPairs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HACK: combined Topkey, key into a single unit64_t.
thrust::sort_by_keyinstead ofcub::DeviceRadixSort::SortPairs