Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BP-1322: Migrate HTTP middlewares from gd-node #180

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andreparames
Copy link
Contributor

These middlewares are used both by gd-node and backend, but they don't depend on the rest of the gd-node. By moving them to the common library, we can in the future remove the dependency between backend and gd-node.

  • Make sure you are opening from a topic/feature/bugfix branch
  • Ensure that the PR title represents the desired changes
  • Ensure that the PR description detail the desired changes
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

These middlewares are used both by gd-node and backend, but
they don't depend on the rest of the gd-node. By moving them
to the common library, we can in the future remove the
dependency between backend and gd-node.
Copy link

guide-bot bot commented Jan 10, 2025

Thanks for opening this Pull Request!
We need you to:

  1. Complete the activities.

    Action: Complete Make sure you are opening from a topic/feature/bugfix branch
    Action: Complete Ensure that the PR title represents the desired changes
    Action: Complete Ensure that the PR description detail the desired changes
    Action: Complete Link to relevant issues in GitHub or Jira
    Action: Complete Link to relevant pull requests, esp. upstream and downstream changes
    Action: Complete Ensure you have provided tests - that demonstrates feature works or fixes the issue

    If an activity is not applicable, use '~activity description~' to mark it not applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant