Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#352: Update error handling and simplify toast integration #565

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

janoliver20
Copy link

Added scrollToFirstError utility to focus on the first error and improved error handling in RelativeScheduler. Replaced manual toast injection with PrimeVue’s useToast for clarity and removed obsolete code. Upgraded to Vue 3.5.13 to ensure compatibility.
#564

Added `scrollToFirstError` utility to focus on the first error and improved error handling in `RelativeScheduler`. Replaced manual toast injection with PrimeVue’s `useToast` for clarity and removed obsolete code. Upgraded to Vue 3.5.13 to ensure compatibility.
@janoliver20 janoliver20 requested a review from ja-fra December 11, 2024 09:13
@janoliver20 janoliver20 self-assigned this Dec 11, 2024
Copy link

github-actions bot commented Dec 11, 2024

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 1a7bdab. ± Comparison against base commit b75eea8.

♻️ This comment has been updated with latest results.

The package-lock.json file was deleted from the repository. This could imply a transition to managing dependencies without a lockfile, possibly to allow flexibility across environments or workflows.
Updated the conditional check for `frontRowActions` to use optional chaining, preventing potential runtime errors when the property is undefined or null. This ensures more robust and error-proof behavior for row action rendering.
@janoliver20 janoliver20 merged commit 418d30a into develop Dec 11, 2024
4 checks passed
@janoliver20 janoliver20 deleted the 350-fixing-bug branch December 11, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants