Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More #302: fix bug where study duration by end date was calculated incorrectly #304

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

drtyyj
Copy link
Contributor

@drtyyj drtyyj commented Jun 4, 2024

This PR fixes a few timeline-flaws:

  • The Duration was not calculated correctly for long-running studies (> one month)
  • Observations and interventions should not expand beyond the study end

Fixes #302

@drtyyj drtyyj requested a review from ja-fra June 4, 2024 10:55
drtyyj and others added 3 commits June 4, 2024 13:05
If the duration is not explicitly set, we assume the duration from participant-start until study-end.
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Test Results

94 tests  ±0   93 ✅ ±0   1m 15s ⏱️ -1s
39 suites ±0    1 💤 ±0 
39 files   ±0    0 ❌ ±0 

Results for commit 391833a. ± Comparison against base commit 78e0d18.

@ja-fra ja-fra requested review from benitsch and removed request for ja-fra June 4, 2024 11:10
@ja-fra ja-fra linked an issue Jun 4, 2024 that may be closed by this pull request
@drtyyj
Copy link
Contributor Author

drtyyj commented Jun 4, 2024

Before merging a PR for the gateway should be prepared, that implements the same changes to SchedulerUtils.

@ja-fra ja-fra merged commit 8324d86 into develop Jun 4, 2024
5 checks passed
@ja-fra ja-fra deleted the 302_timeline_bugfixes branch June 4, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix some timeline inconsistency bugs
3 participants