Export check output target runner #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is OK, but for an exported function, I would prefer to not use "." in function names, because that is problematic for several reasons. Please rename the function to |
|
Thanks. I am currently trying to enjoy some holiday for a few days. So I will make these changes later. |
…xport check_output_target_runner
DE0CH
force-pushed
the
feature/export-check-output-target-runner-2
branch
from
6626de6 to
bc770bb
Compare
|
I've made the changes. Please review. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exporting this function would benefit a new feature made in
iracepy(auto-optimization/iracepy#22). Using theexec.target.runneris problematic because for some reason I cannot pass an r function through a python Queue (see more details in the PR auto-optimization/iracepy#22).