Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #82 #83

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Fix for #82 #83

merged 1 commit into from
Dec 19, 2023

Conversation

ciscorn
Copy link
Member

@ciscorn ciscorn commented Dec 19, 2023

#82 でマージを失敗して main のビルドが通らない状態になっています。修正します。

@ciscorn ciscorn requested review from xinmiaooo and a team December 19, 2023 01:23
@ciscorn ciscorn self-assigned this Dec 19, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
Components Coverage Δ
GUI ∅ <ø> (∅)
Backend 67.37% <100.00%> (∅)
Libraries 82.79% <ø> (∅)

📢 Thoughts on this report? Let us know!

xinmiaooo
xinmiaooo approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@xinmiaooo xinmiaooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます、LGTM！

@xinmiaooo xinmiaooo merged commit 878acae into main Dec 19, 2023
4 checks passed
@xinmiaooo xinmiaooo deleted the hotfix-for-82 branch December 19, 2023 01:33
@sorami sorami mentioned this pull request Dec 19, 2023
Merged
sorami added a commit that referenced this pull request Dec 19, 2023
@sorami
nusamai-geojson: exampleの修正 (#85)
3665be8 
2行だけの簡単な変更です！

- #82, #83 での変更
- 名前が `nusamai_plateau::models::CityObject` から
`nusamai_plateau::models::TopLevelCityObject` に変わった
- nusamai-geojson
  - #79 で対応した（Tauri部分）
  - exampleでの修正が漏れていた
ciscorn pushed a commit that referenced this pull request Dec 27, 2023
@sorami @ciscorn
nusamai-geojson: exampleの修正 (#85)
aedf8d5 
2行だけの簡単な変更です！

- #82, #83 での変更
- 名前が `nusamai_plateau::models::CityObject` から
`nusamai_plateau::models::TopLevelCityObject` に変わった
- nusamai-geojson
  - #79 で対応した（Tauri部分）
  - exampleでの修正が漏れていた
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinmiaooo xinmiaooo xinmiaooo approved these changes

Assignees

@ciscorn ciscorn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ciscorn @xinmiaooo