Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

データパイプラインの概形を作る #63

Merged
merged 6 commits into from
Dec 14, 2023

Conversation

ciscorn
Copy link
Member

@ciscorn ciscorn commented Dec 13, 2023

See #44

データ処理パイプライン [Source (Input)] ==> [Transform] ==> [Sink (Output)] の概形を作りました。

  • Source や Sink から Controller にフィードバック(エラー、進捗状況、etc.)を送る仕組みも実装してあります。
  • パイプラインを停止する(ユーザなどがキャンセルする)仕組みも備えています。
  • Source や Sink のための Configurations の仕組みのなんとなくの大枠を用意してありますが、具体的な実装はまだありません。

テストは、「パイプライン走らせて、途中でキャンセルする」ことだけしている。test coverage:

Screenshot 2023-12-14 at 14 26 15

Closes: #44

@ciscorn ciscorn self-assigned this Dec 13, 2023
@ciscorn ciscorn marked this pull request as draft December 13, 2023 14:05
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Files Patch % Lines
nusamai/src/configuration.rs 9.09% 10 Missing ⚠️
Additional details and impacted files
Components Coverage Δ
GUI ∅ <ø> (∅)
Backend 90.65% <90.65%> (∅)
Libraries 79.36% <ø> (ø)

📢 Thoughts on this report? Let us know!

@ciscorn ciscorn force-pushed the feature/pipeline-outline branch 2 times, most recently from e24f26f to c1f72d2 Compare December 14, 2023 04:16
@ciscorn ciscorn force-pushed the feature/pipeline-outline branch from c1f72d2 to 3682a66 Compare December 14, 2023 04:50
@ciscorn ciscorn force-pushed the feature/pipeline-outline branch from 34f9951 to f58fddd Compare December 14, 2023 05:01
@ciscorn ciscorn marked this pull request as ready for review December 14, 2023 05:19
@ciscorn ciscorn requested a review from a team December 14, 2023 05:19
nusamai/src/configuration.rs Outdated Show resolved Hide resolved
@ciscorn ciscorn changed the title [WIP] パイプラインの概形を作る データパイプラインの概形を作る Dec 14, 2023
@ciscorn ciscorn force-pushed the feature/pipeline-outline branch from 142a9e8 to a83dc76 Compare December 14, 2023 06:28
Copy link
Member

@sorami sorami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ciscorn ciscorn merged commit d8c8070 into main Dec 14, 2023
4 checks passed
@ciscorn ciscorn deleted the feature/pipeline-outline branch December 14, 2023 08:41
ciscorn added a commit that referenced this pull request Dec 27, 2023
See #44 

データ処理パイプライン `[Source (Input)] ==> [Transform] ==> [Sink (Output)]`
の概形を作りました。

- Source や Sink から Controller にフィードバック(エラー、進捗状況、etc.)を送る仕組みも実装してあります。
- パイプラインを停止する(ユーザなどがキャンセルする)仕組みも備えています。
- Source や Sink のための Configurations
の仕組みのなんとなくの大枠を用意してありますが、具体的な実装はまだありません。

テストは、「パイプライン走らせて、途中でキャンセルする」ことだけしている。test coverage:

<img width="356" alt="Screenshot 2023-12-14 at 14 26 15"
src="https://github.com/MIERUNE/nusamai/assets/5351911/e9ab9324-e770-4803-af32-25e529afa7ee">

Closes: #44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

データパイプラインの大枠を設計する
2 participants