Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lng/lat を Web Mercator に変換する関数 #32

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Conversation

ciscorn
Copy link
Member

@ciscorn ciscorn commented Dec 4, 2023

地理座標とWeb Mercatorを相互変換するだけの関数を用意します。

MVT形式でしか使わない予定なので、ひとまず nusamai-mvt 内に作りました。

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
Components Coverage Δ
tauri-app 0.00% <ø> (ø)
nusamai-* 59.80% <100.00%> (+0.72%) ⬆️

📢 Thoughts on this report? Let us know!

@ciscorn ciscorn marked this pull request as ready for review December 4, 2023 00:56
@ciscorn ciscorn requested review from sorami and a team December 4, 2023 00:56
@ciscorn ciscorn self-assigned this Dec 4, 2023
Copy link
Member

@sorami sorami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

処理、LGTMです!


このコミット↓は、 #31 のものですかね?このPRの範囲においては、除外して良いかと思いました。

2cf6043


あとは、nitsですが、コメントした nusamai-gmvt/Cargo.toml でのパッケージ名だけご確認いただければと!

nusamai-mvt/src/webmercator.rs Outdated Show resolved Hide resolved
nusamai-mvt/src/webmercator.rs Show resolved Hide resolved
nusamai-mvt/Cargo.toml Outdated Show resolved Hide resolved
@ciscorn ciscorn force-pushed the feature/webmercator branch from fcf2785 to 062af7a Compare December 4, 2023 12:43
@ciscorn ciscorn requested a review from sorami December 4, 2023 12:46
@ciscorn
Copy link
Member Author

ciscorn commented Dec 4, 2023

@sorami ご指摘の点、修正しました!!

Copy link
Member

@sorami sorami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@ciscorn ciscorn merged commit 1c228b7 into main Dec 5, 2023
3 checks passed
@ciscorn ciscorn deleted the feature/webmercator branch December 5, 2023 01:21
ciscorn added a commit that referenced this pull request Dec 27, 2023
地理座標とWeb Mercatorを相互変換するだけの関数を用意します。

MVT形式でしか使わない予定なので、ひとまず `nusamai-mvt` 内に作りました。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants