Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cross build compilation CI #29

Merged
merged 6 commits into from
Dec 4, 2023
Merged

cross build compilation CI #29

merged 6 commits into from
Dec 4, 2023

Conversation

xinmiaooo
Copy link
Member

@xinmiaooo xinmiaooo commented Nov 27, 2023 •
edited by ciscorn
Loading

  • releaseが作成されたらWindowsとMac用にインストーラーが自動作成され、releaseからダウンロードできる
  • イメージ：https://github.com/MIERUNE/tauri-build-sample/releases
  • また、ビルドするために、tauriのidentifierを変えています。
Error You must change the bundle identifier in `tauri.conf.json > tauri > bundle > identifier`. The default Value `com.tauri.dev` is not allowed as it must be unique across applications.
  • github actionsを発火させるために、このようなテスト手順になります
    　- mainブランチにマージ
    　- releaseを発行
    　- actionが正常終了したら、ファイルをローカルにダウンロード
    　

@xinmiaooo xinmiaooo marked this pull request as draft November 27, 2023 09:10
@xinmiaooo xinmiaooo changed the title cross build compilation ci cross build compilation CI Nov 27, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
Components Coverage Δ
tauri-app 0.00% <ø> (ø)
nusamai-* 59.07% <ø> (-35.21%) ⬇️

📢 Thoughts on this report? Let us know!

@xinmiaooo xinmiaooo requested review from sorami and ciscorn November 30, 2023 02:34
@xinmiaooo xinmiaooo marked this pull request as ready for review November 30, 2023 02:34
ciscorn
ciscorn approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@ciscorn ciscorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMですが、identifier についてだけコメントしました〜

app/src-tauri/tauri.conf.json Outdated Show resolved Hide resolved
.github/workflows/cross-platform-compilation.yaml Show resolved Hide resolved
@ciscorn
Copy link
Member

ciscorn commented Dec 4, 2023

nusamai はPR上げたひとがマージする形でやっていますが、今回はこちらでマージしちゃいますね。

@ciscorn ciscorn merged commit a74c6b0 into main Dec 4, 2023
2 of 3 checks passed
@ciscorn ciscorn deleted the build-ci branch December 4, 2023 09:52
ciscorn pushed a commit that referenced this pull request Dec 27, 2023
@xinmiaooo @ciscorn
cross build compilation CI (#29)
4641c70 
- releaseが作成されたらWindowsとMac用にインストーラーが自動作成され、releaseからダウンロードできる
- イメージ：https://github.com/MIERUNE/tauri-build-sample/releases
- また、ビルドするために、tauriのidentifierを変えています。
 ```
Error You must change the bundle identifier in `tauri.conf.json > tauri
> bundle > identifier`. The default Value `com.tauri.dev` is not allowed
as it must be unique across applications.
```

- github actionsを発火させるために、このようなテスト手順になります
　- mainブランチにマージ
　- releaseを発行
　- actionが正常終了したら、ファイルをローカルにダウンロード
　
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciscorn ciscorn ciscorn approved these changes

@sorami sorami Awaiting requested review from sorami

@nokonoko1203 nokonoko1203 Awaiting requested review from nokonoko1203

Assignees

@xinmiaooo xinmiaooo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xinmiaooo @ciscorn