Skip to content

Commit

Permalink
Todo
Browse files Browse the repository at this point in the history
  • Loading branch information
jacquev6 committed Sep 25, 2023
1 parent dbc4573 commit 585ba42
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions lincs/command_line_interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ def classification_problem(
if allow_decreasing_criteria:
command_line += ["--allow-decreasing-criteria"]
print(f"# Reproduction command: {' '.join(str(c) for c in command_line)}", file=output_problem, flush=True)
# @todo(Feature, later) Add a line saying which version of lincs was used

problem = lincs.generate_classification_problem(
criteria_count,
Expand Down
4 changes: 4 additions & 0 deletions lincs/liblincs/learning/mrsort-by-weights-profiles-breed.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ Model LearnMrsortByWeightsProfilesBreed::perform() {
}

// Succeed?
// @todo(Feature, later) Let the user know which exit condition was reached
// (Maybe via a comment in the output file, like the "Reproduction command:" line)
if (new_best_accuracy == learning_data.learning_alternatives_count || termination_strategy.terminate()) {
for (auto observer : observers) {
observer->before_return();
Expand All @@ -132,6 +134,8 @@ Model LearnMrsortByWeightsProfilesBreed::perform() {
}

// Fail
// @todo(Feature, later) Exit consistently with the other exit conditions:
// Don't fail, return the best model so far, and let the user know which exit condition was reached
throw LearningFailureException();
}

Expand Down

0 comments on commit 585ba42

Please sign in to comment.