Descriptive file names, VaultConnector implementation and tests, Key services implementation #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGTheTrain
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
MGTheTrain
force-pushed
the
opt/general
branch
from
fdbb6da
to
24d0c7d
Compare
MGTheTrain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGELOG.mdincludes comprehensive documentation for the implemented features or fixed bugs. Increment the minor version such asfrom 0.1.0 to 0.2.0for implemented features and increment the patch versionfrom 0.1.0 to 0.1.1for bug fixes. If any breaking changes occur, increment the major version, likefrom 0.1.0 to 1.0.0. Also see Semantic Versioning 2.0.0Reference/Link to the issue solved with this PR (if any)