Begin migration to use System.FilePath for implementation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions to iOS v15, add visionOS platform feature/system-FilePath
…Windows, etc) feature/system-FilePath
feature/system-FilePath
feature/system-FilePath
r-jarvis
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Systemframework on Apple platforms andSystemPackageon others offers theFilePathtype that can replace most of if not all the custom andNSStringbased logic. This first PR makes minimal changes without knowingly changing any behavior.The
SystemPackageimplementation ofFilePathwill addSendableconformance in the next version but is not present yet. As such,@unchecked Sendableconformance has been added toFilePathfor now.FilePathis an iOS 14+ framework with parts of the API requiring iOS 15+. This package's platform requirements have been raised to match.For the sake of completeness, visionOS has been added as a platform which requires Swift 5.9+. There's little downside to raising the package's minimum so it is now 5.9.