Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more stable yeo johnson roundtrips #494

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

mathause
Copy link
Member

@mathause mathause commented Aug 12, 2024

With this we can take another stab at #476. It also seems a bit faster. Modeled after scikit-learn/scikit-learn#26188

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.11%. Comparing base (9b0b76b) to head (3c12f01).
Report is 127 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #494       +/-   ##
===========================================
- Coverage   87.90%   50.11%   -37.80%     
===========================================
  Files          40       50       +10     
  Lines        1745     3512     +1767     
===========================================
+ Hits         1534     1760      +226     
- Misses        211     1752     +1541     
Flag Coverage Δ
unittests 50.11% <100.00%> (-37.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veni-vidi-vici-dormivi
Copy link
Collaborator

Huh interesting, so that means that np.power yields less precision than np.exp and np.log, right? That's good to know.

@mathause
Copy link
Member Author

Thanks. I think its more the np.expm1 and np.log1p. From the docstrings:

  • expm1: This function provides greater precision than exp(x) - 1 for small values of x.
  • log1p: For real-valued input, log1p is accurate also for x so small that 1 + x == 1 in floating-point accuracy.

(interesting the names are not symmetric...)

@mathause mathause merged commit ee2916c into MESMER-group:main Aug 13, 2024
9 checks passed
@mathause mathause deleted the stabilize_yeo_johnson branch August 13, 2024 10:28
@veni-vidi-vici-dormivi
Copy link
Collaborator

Interesting. Thanks for doing that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants