add calc_gaspari_cohn_correlation_matrices #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
==========================================
+ Coverage 86.89% 86.92% +0.02%
==========================================
Files 38 38
Lines 1580 1583 +3
==========================================
+ Hits 1373 1376 +3
Misses 207 207
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
I'm ignoring the faulty rtd built. I think it's a fluke. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isort . && black . && flake8CHANGELOG.rstAdd function to calculate Gaspari-Cohn correlation matrices for a range of localisation radii. Again, blatantly stolen from #109, so @znicholls should really get the credit here. I pass
geodistinstead oflon, latbecause I still intend to do #62 and for this it is much easier if we pass the geodist directly. Makes it also a bit more explicit what is happening.The tests are crap - they repeat the code in the function, which renders almost worthless. Still it checks that it is run.