Create a better LED System and LED Subsystem #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will be removed in the next update as i don't like redoing what the command scheduler already did. so will create a singleton LEDSubsystem and get the subsystem trough the LEDSystem.java by doing `LEDSystem.getInstance()`
So many changes have been made, it now uses a fully diffrent system taking in LED Commands that are special classes similar to wpilib's classes but simpler, so that the implementation is simpler. The only problem is interrupting a task is impossible so there is an option to force remove elements from the call list, as the scheduler WILL wait for that command to finish.
This will offload most of my work to at least the main command scheduler, now; all I need to do is handle the led scheduler only. and that implementation is basic anyways
This will handle the red or green from intake or orange if disabled
This can be used anywhere and looks REAL FCKING COOL
This will make shooting look a lot cooler
Now its perfect
this will setup the idle command to run when the led subsystem isn't being run. This was the best way to handle default command for LED System. maybe it could have been setup with my own command scheduler like system. But i prefer using this
This will make the LED's blink red while intaking. I might change this to a bottom to top effect instead, as that might give the info that it expects a note from the ground.
I left a bug in SmartIntakeCommand... Now its fixed 😁👍 (I debugged this for a couple hours...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a simple Command Scheduler and added a custom Command type, that is much simpler than the typical Command