Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new command tests and add extra fixes #14

Merged
merged 13 commits into from
Jun 19, 2024
Merged

Create new command tests and add extra fixes #14

merged 13 commits into from
Jun 19, 2024

Conversation

kytpbs
Copy link
Member

@kytpbs kytpbs commented Jun 19, 2024

This does a couple of different things at a single PR (mostly because I forgot to switch branches and didn't want to merge without first testing it, but yolo it is) some of which:

  1. Update GitHub Actions to use multiple OS's that our devs might be using (MACs might be used in the future but they still fail due to unknown reasons that cannot be tested further without a Mac on my hands)
  2. Add new tests that increase the code coverage to more than 50%
  3. Add extra QoL features that simplify and abstract some parts away.
  4. Remove the reliance on a vendor for testing (SparkMAXWrapping for testing)

This PR also does update some parts of the DriveSubsystem, but it does not create any changes in behavior (at least as much as I could test, it doesn't).

kytpbs added 13 commits May 31, 2024 17:11
Also moves boost by to a seperate variable which explains a lot more imo
calculation simplified by using a calculator, so it has a very low chance of being wrong yey!
I wanted to support mac too but half of the tests somehow fail, so without a mac on my hands I won't support it
this should fix a lot of the auto issues.
* update to use .runEnd instead of run

this should fix a lot of the auto issues.

* make the green blink a part of the parallel race group

* Update path and autos

* [Dependency] bump wpilib to 2024.3.2

* rename "SmartShootCommand" to "ShootToSpeakerCommand"

This represents what it is about a lot better in my opinion.

* Fix tests by not shutting down the hal in teardown

* close the subsystem after super in basicIntakeTest

* add more comments for explanation

* don't shutdown HAL in DriveSubsystem test base
this abstracts the motor controller type away from the tests, so it is easier to change the motor controller type while the tests still work correctly.
setNoteColor abstracts away the set values on the color setting for note so if they need to be changed, its only on 1 place
@kytpbs kytpbs merged commit f588f81 into master Jun 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant