Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor build script & GitHub Actions improvements #39

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Minor build script & GitHub Actions improvements #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0d4a8a
Misc. Gradle build script cleanup
NeRdTheNed Jun 8, 2023
5650792
Configure Gradle to create reproducible archives
NeRdTheNed Jun 8, 2023
5533212
Use Java toolchains
NeRdTheNed Jun 8, 2023
b48ce65
Don't use hardcoded file name for release artifact
NeRdTheNed Jun 8, 2023
80b628e
Disable the Gradle cache for release builds
NeRdTheNed Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
uses: gradle/gradle-build-action@v2
with:
gradle-version: wrapper
cache-read-only: ${{ github.ref != 'refs/heads/master' }}
cache-disabled: true
# specify the build version, overrides whatever is in the build.gradle file
arguments: build -PoverrideVersion=${{ env.VERSION }}

Expand All @@ -45,5 +45,4 @@ jobs:
name: Neko Detector ${{ env.VERSION }}
draft: true
prerelease: false
files: |
jarscanner-${{ env.VERSION }}.jar
files: build/libs/*
20 changes: 17 additions & 3 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,30 @@
plugins {
id "java"
id("com.github.johnrengelman.shadow") version "8.1.1"
id("com.github.johnrengelman.shadow") version "8.1.1"
}
group 'me.cortex'
version '1.0-SNAPSHOT'

sourceCompatibility = 1.8
targetCompatibility = 1.8

java {
toolchain {
languageVersion = JavaLanguageVersion.of(8)
}
}

repositories {
mavenCentral()
}

// Reproducible builds
// https://docs.gradle.org/current/userguide/working_with_files.html#sec:reproducible_archives
tasks.withType(AbstractArchiveTask).configureEach {
preserveFileTimestamps = false
reproducibleFileOrder = true
}

dependencies {
implementation 'org.ow2.asm:asm:9.5'
implementation 'org.ow2.asm:asm-tree:9.5'
Expand All @@ -20,13 +34,13 @@ test {
useJUnitPlatform()
}


tasks.shadowJar {
archiveClassifier.set("")
manifest {
attributes "Main-Class": "me.cortex.jarscanner.Main"
}
}

tasks.build {
dependsOn(shadowJar)
if (project.hasProperty("overrideVersion")) {
Expand All @@ -39,4 +53,4 @@ jar {
manifest {
attributes 'Main-Class': 'me.cortex.jarscanner.Main'
}
}
}