Skip to content

Commit

Permalink
Enforce x86_64 Python for x86_64-only build
Browse files Browse the repository at this point in the history
  • Loading branch information
spotlightishere committed May 17, 2024
1 parent 1f823b9 commit 6f1b13c
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions .github/workflows/actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ jobs:
- pyqt5
steps:
- uses: actions/checkout@v4

- uses: actions/setup-python@v5
with:
python-version: 3.11.4
Expand All @@ -34,7 +33,7 @@ jobs:
run: mv client/dist/NSO-RPC.exe client/dist/NSO-RPC-qt5.exe
- name: Upload Build
if: github.event_name != 'pull_request'
uses: softprops/action-gh-release@v2.0.4
uses: softprops/action-gh-release@v2
with:
files: |
client/dist/NSO-RPC*.exe
Expand All @@ -53,19 +52,18 @@ jobs:
continue-on-error: false
- name: Upload Build
if: github.event_name != 'pull_request'
uses: softprops/action-gh-release@v2.0.4
uses: softprops/action-gh-release@v2
with:
files: scripts/linux.sh
build-macos:
name: Build NSO-RPC - MacOS
# We cannot use arm64 macOS runners until setup-python permits specifying an architecture.
# See also: https://github.com/actions/setup-python/issues/547
runs-on: macos-12
runs-on: macos-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: 3.11.4
architecture: x64
# We initially use `arch -x86_64` to ensure that we use an x86_64 version
# of Python, regardless of the host architecture.
# Subsequent invocations will all use the x86_64 `python3` binary within the venv.
Expand All @@ -83,7 +81,7 @@ jobs:
zip -yr mac-portable.zip NSO-RPC.app/
- name: Upload Build
if: github.event_name != 'pull_request'
uses: softprops/action-gh-release@v2.0.4
uses: softprops/action-gh-release@v2
with:
files: |
client/dist/mac-installer.dmg
Expand All @@ -93,7 +91,7 @@ jobs:
runs-on: macos-latest
steps:
- uses: actions/checkout@v4
- name: Install Python 3.11.4 and build NSO-RPC
- name: Install Universal Python 3.11.4
run: >
curl https://www.python.org/ftp/python/3.11.4/python-3.11.4-macos11.pkg -o python-3.11.4-macos11.pkg &&
sudo installer -verbose -pkg python-3.11.4-macos11.pkg -target /
Expand All @@ -112,7 +110,7 @@ jobs:
zip -yr mac-universal2-portable.zip NSO-RPC.app/
- name: Upload NSO-RPC Universal2 Build
if: github.event_name != 'pull_request'
uses: softprops/action-gh-release@v2.0.4
uses: softprops/action-gh-release@v2
with:
files: |
client/dist/mac-universal2-installer.dmg
Expand All @@ -133,6 +131,6 @@ jobs:
hash-type: sha256
file-name: checksums.txt
get-assets: true
- uses: softprops/action-gh-release@v2.0.4
- uses: softprops/action-gh-release@v2
with:
files: checksums.txt

0 comments on commit 6f1b13c

Please sign in to comment.