Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

存在本地歌词跳过搜索 #11

Merged
merged 7 commits into from
Sep 27, 2024

Conversation

PercyDan54
Copy link
Contributor

@PercyDan54 PercyDan54 commented Sep 23, 2024

修复存在用户定义的歌曲延迟被反复覆盖
本地歌词检查被查了两遍,该怎么清理下

@MATRIX-feather
Copy link
Owner

MATRIX-feather commented Sep 26, 2024

好一个强迫症

关于本地歌词被检查了两遍,我之后看看要怎么搞

@@ -155,7 +155,7 @@ public List<Lyric> ToLyricList()
foreach (var lrc in result.FindAll(l => l.Time == time))
{
lrc.TranslatedString = lyricContent;
//Logging.Log($"设置歌词歌词: {lrc}");
//Logger.Log($"设置歌词: {lrc}");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果没有什么特殊原因的话Logger调用最好替换为Logging来避免和osu的日志混在一起

@MATRIX-feather MATRIX-feather merged commit a3730b9 into MATRIX-feather:ruleset Sep 27, 2024
1 check passed
@PercyDan54 PercyDan54 deleted the skip-existing branch October 27, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants